[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 28 17:44:07 PDT 2020


njames93 added a comment.

I'm not entirely sure this is where the fix needs to be for this. The test case code is whacky as hell, but from what I can see clang should always emit a `BinaryOperator` for dependent type operators. No idea why it is spewing out a `CXXOperatorCallExpr` instead. Would need someone with more knowledge on Sema to confirm(or deny) this though.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unhandled-self-assignment.cpp:516
 public:
-  NotACopyAssignmentOperator& operator=(const NotACopyAssignmentOperator<Uy, Ty> &RHS) {
+  NotACopyAssignmentOperator &operator=(const NotACopyAssignmentOperator<Uy, Ty> &RHS) {
     Ptr1 = RHS.getUy();
----------------
clang format artefact? This change should be undone as its unrelated to the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76990/new/

https://reviews.llvm.org/D76990





More information about the cfe-commits mailing list