[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

Sat Mar 28 13:27:33 PDT 2020

atmnpatel added a comment.

> In D75591#1936152 <https://reviews.llvm.org/D75591#1936152>, @lebedev.ri wrote:
>  It should be handled consistently with how other newer openmp features are handled with older openmp version specified.

In terms of consistency, the newer openmp features are handled as errors thrown, not as warnings. In this particular case however, it might make more sense to keep this as a warning rather than an error because its functionality doesn't exactly rely on a particular openmp version. I have it written out as an error now, but it doesn't quite sit right with me as an error yet.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75591/new/

https://reviews.llvm.org/D75591