[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 28 10:12:44 PDT 2020


nridge marked an inline comment as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:708-710
+    return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName,
+                    M1.Message) <
+           std::tie(M2.FilePath, M2.FileOffset, RHS.DiagnosticName, M2.Message);
----------------
njames93 wrote:
> This looks like a clang-format artifact, there are several other below. Could these be removed from this patch
If you insist, I can move them to a separate patch. I don't want to leave it unmodified because the change will come back every time someone touches the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75286/new/

https://reviews.llvm.org/D75286





More information about the cfe-commits mailing list