[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 27 20:23:42 PDT 2020


yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:271
                              const ToolChain &HostTC, const ArgList &Args)
-    : ToolChain(D, Triple, Args), HostTC(HostTC) {
+    : ROCMToolChain(D, Triple, Args), HostTC(HostTC) {
   // Lookup binaries into the driver directory, this is used to
----------------
I did not see ROCMToolChain in clang trunk. Is it in another patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76887/new/

https://reviews.llvm.org/D76887





More information about the cfe-commits mailing list