[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 27 19:17:54 PDT 2020


sbc100 added inline comments.


================
Comment at: clang/lib/Headers/wasm_simd128.h:10
+
+#pragma once
+
----------------
tlively wrote:
> sunfish wrote:
> > Do you know why other clang headers, such as `lib/Headers/xmmintrin.h`, don't use `#pragma once`?
> No, I don't know. According to https://github.com/emscripten-core/emscripten/pull/9299#discussion_r316893349 `#pragma once` is the convention in Emscripten's header files, but I don't know what the trade offs are. @sbc100 do you have a better answer for this?
I think you should follow the local conventions.   For whatever reason `#pramga once` never really seems to take off (emscripten is the only project I know of that uses it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76959/new/

https://reviews.llvm.org/D76959





More information about the cfe-commits mailing list