[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

[Niko Weh via Phabricator via cfe-commits]

niko added a comment.

In D76496#1935127 <https://reviews.llvm.org/D76496#1935127>, @njames93 wrote:

> I'm not hugely familiar with the abseil library, but from what I can see `absl::StartsWith` takes `absl::string_view` as args. Therefore surely it makes sense to handle the 3rd arg for `str::find` by explicitly constructing the `absl::string_view` from the pointer and size.


I am mainly worried that the 3-arg find is rarely used, and using absl::string_view requires another option to be specified for the header file. If you think that's still a good tradeoff i'll change it to construct a string_view.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76496/new/

https://reviews.llvm.org/D76496