[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 27 08:13:00 PDT 2020


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Thanks a lot!



================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:301
+                                    bool AllowIO) {
+  // This is similar to the implementation of SourceManager::getCharacterData(),
+  // but uses ContentCache::getRawBuffer() rather than getBuffer() if
----------------
nit: the peer function to reference is SourceManager::getBufferData


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75286/new/

https://reviews.llvm.org/D75286





More information about the cfe-commits mailing list