[clang] 819e540 - Use llvm_unreachable after a fully covered/always-returning switch

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 26 20:14:33 PDT 2020


Author: David Blaikie
Date: 2020-03-26T20:09:57-07:00
New Revision: 819e540208d5d62e7841d0dbdef3580eecc2c2b6

URL: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6
DIFF: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6.diff

LOG: Use llvm_unreachable after a fully covered/always-returning switch

Added: 
    

Modified: 
    clang/lib/Basic/Targets/X86.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Basic/Targets/X86.cpp b/clang/lib/Basic/Targets/X86.cpp
index 8a7d0f17760e..f06bf84cfd99 100644
--- a/clang/lib/Basic/Targets/X86.cpp
+++ b/clang/lib/Basic/Targets/X86.cpp
@@ -1842,7 +1842,7 @@ Optional<unsigned> X86TargetInfo::getCPUCacheLineSize() const {
     case CK_Generic:
       return None;
   }
-  return None;
+  llvm_unreachable("Unknown CPU kind");
 }
 
 bool X86TargetInfo::validateOutputSize(const llvm::StringMap<bool> &FeatureMap,


        


More information about the cfe-commits mailing list