[PATCH] D76696: [AST] Build recovery expressions by default for C++.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 26 13:02:52 PDT 2020


sammccall added a comment.

In D76696#1944625 <https://reviews.llvm.org/D76696#1944625>, @hubert.reinterpretcast wrote:

> All of them appear to have unresolved names in constexpr evaluation. It is likely to be the same issue.


The general scheme is probably common: unresolved expr -> ??? -> an expression is dependent but not marked as such -> constant evaluation crashes.

But the ??? matters, as that's where the fix is.
In the case above: expr is used in a member of X, and X is not a dependent type, so sizeof(X) is not considered dependent


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76696/new/

https://reviews.llvm.org/D76696





More information about the cfe-commits mailing list