[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 26 11:23:02 PDT 2020


sbc100 marked 3 inline comments as done.
sbc100 added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:143
 
+  if (llvm::sys::path::is_relative(SysRoot)) {
+    // Prepend InstalledDir if SysRoot is relative
----------------
phosek wrote:
> Does this return `true` or `false` when sysroot is empty?
Good questions.  As it happens it looks like it returns true, which is not the result we want here.  Added explicit check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76653/new/

https://reviews.llvm.org/D76653





More information about the cfe-commits mailing list