[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 26 11:23:00 PDT 2020


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:452
+  const HighlightingToken *Last = nullptr;
+  for (const HighlightingToken &Tok : Tokens) {
+    Result.emplace_back();
----------------
hokein wrote:
> note that we don't calculate the column offset for `InactiveCode` token (`{(line, 0), (line, 0)}`), I think we probably calculate the range with the new implementation, maybe add a FIXME.
Right, yes. Just skipping over them for now, with a fixme.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76663/new/

https://reviews.llvm.org/D76663





More information about the cfe-commits mailing list