[PATCH] D76696: [AST] Build recovery expressions by default for C++.

Thu Mar 26 10:50:33 PDT 2020

sammccall added a comment.

@ebevhan Thanks again for the testcase. I've added a reduced version in 47e7bdb10732e6f140adce39a1bc34e3ee2a6ea6 <https://reviews.llvm.org/rG47e7bdb10732e6f140adce39a1bc34e3ee2a6ea6> to ensure this is fixed on re-land.
This particular case can be fixed by marking the decl as invalid I think, I'm curious how this generalizes.

In D76696#1944014 <https://reviews.llvm.org/D76696#1944014>, @hubert.reinterpretcast wrote:

> We have also encountered crashes in downstream testing caused by this using just the vanilla source from trunk. When there is a proposed fix, please let us know so we can test. Thanks.

We can try but it would be very useful to have details, no idea whether it's going to be the same issue and the more we know about the easier it is to improve the design.
Can you describe the case at all? Any chance of a minimal example? Ideally we'd check it in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76696/new/

https://reviews.llvm.org/D76696