[PATCH] D72281: [Matrix] Add matrix type to Clang.
Florian Hahn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 25 11:53:41 PDT 2020
fhahn added a reviewer: rjmccall.
fhahn marked 2 inline comments as done.
fhahn added inline comments.
================
Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:647
+ return false;
+ if (Mat1->getNumRows() != Mat2->getNumRows())
+ return false;
----------------
martong wrote:
> Should we check `getNumColumns()` too?
Yes, thanks! Should be fixed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72281/new/
https://reviews.llvm.org/D72281
More information about the cfe-commits
mailing list