[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

Wed Mar 25 08:04:47 PDT 2020

njames93 added a comment.

In D76761#1941070 <https://reviews.llvm.org/D76761#1941070>, @gribozavr2 wrote:

> Could you provide more information about why these null checks are needed in this case?

Well the fact it was crashing without those null checks was the reason they were added. I'm not 100% sure of the root cause and this could just be a case of applying a plaster to a broken arm. I'm guessing the root cause of the crash is the fact the callee is a `CXXMethodDecl` which is not being handled but I honestly don't know.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76761/new/

https://reviews.llvm.org/D76761