[PATCH] D76572: Replace `T(x)` with `reinterpret_cast<T>(x)` everywhere it means reinterpret_cast. No functional change
James Henderson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 25 01:35:35 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
LGTM, with nit, with regards to the llvm-readobj and libObject parts. I haven't looked at the other bits though.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/OcamlGCPrinter.cpp:150
+ ">= 65536.\n"
+ "(" +
+ Twine(reinterpret_cast<uintptr_t>(&FI)) + ")");
----------------
Nit: I think you can fold these two string literals together. Not sure why they were separate before.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76572/new/
https://reviews.llvm.org/D76572
More information about the cfe-commits
mailing list