[clang] 7339fca - Revert "Convert a reachable llvm_unreachable into an assert."

[Aaron Ballman via cfe-commits]

Author: Aaron Ballman
Date: 2020-03-24T16:06:14-04:00
New Revision: 7339fca25facb566e969b6ce01f23ac96499d574

URL: https://github.com/llvm/llvm-project/commit/7339fca25facb566e969b6ce01f23ac96499d574
DIFF: https://github.com/llvm/llvm-project/commit/7339fca25facb566e969b6ce01f23ac96499d574.diff

LOG: Revert "Convert a reachable llvm_unreachable into an assert."

This reverts commit 4a0267e3ad8c4d47f267d7d960f127e099fb4818.

Added: 
    

Modified: 
    clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp b/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
index 99e16752b51a..01ac2bc83bb6 100644
--- a/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
+++ b/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
@@ -134,9 +134,9 @@ StringRef AnalyzerOptions::getCheckerStringOption(StringRef CheckerName,
     CheckerName = CheckerName.substr(0, Pos);
   } while (!CheckerName.empty() && SearchInParents);
 
-  assert(false && "Unknown checker option! Did you call getChecker*Option "
-                  "with incorrect parameters? User input must've been "
-                  "verified by CheckerRegistry.");
+  llvm_unreachable("Unknown checker option! Did you call getChecker*Option "
+                   "with incorrect parameters? User input must've been "
+                   "verified by CheckerRegistry.");
 
   return "";
 }