[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you for this cleanup!



================
Comment at: clang/lib/Basic/Attributes.cpp:89
   SmallString<64> FullName = ScopeName;
-  if (Scope || SyntaxUsed == AttributeCommonInfo::AS_CXX11 ||
-      SyntaxUsed == AttributeCommonInfo::AS_C2x)
+  if (!ScopeName.empty())
     FullName += "::";
----------------
I think we should add an assert that the syntax used is either CXX11 or C2x if the scope name is not empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76704/new/

https://reviews.llvm.org/D76704