[PATCH] D76696: [AST] Build recovery expressions by default for C++.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 24 10:12:05 PDT 2020


sammccall added a comment.

Do you also want to update LangOpts.td to make the default for the langopt equal to CPlusPlus?
(I saw other opts doing that, not sure exactly what it affects, may be voodoo cargo cult stuff)



================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1198
     #define ID(X) X
-      ID(foo $p^( foo(10), ^ ))
+      ID(foo $p^( 10, ^ ))
     })cpp"};
----------------
Why did the original test start failing? Is this a regression?

(This certainly seems OK to regress and fix later, but there may be other consequences?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76696/new/

https://reviews.llvm.org/D76696





More information about the cfe-commits mailing list