[PATCH] D76605: [analyzer] Display the checker name in the text output
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 24 04:48:13 PDT 2020
NoQ added inline comments.
================
Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316
+ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "display-checker-name",
+ "Display the checker name for textual outputs",
+ true)
+
----------------
Szelethus wrote:
> NoQ wrote:
> > Why do we need an option? Is it just for tests? Is it for clang-tidy to avoid printing the checker name twice?
> >
> > Why do we need an option?
>
> Well, we don't, but there is just no reason not to make this configurable, as seen in the debug checker test file. It would be unnecessary noise in their case.
>
> > Is it just for tests?
>
> Tests are a big motivating factor, but it just doesn't hurt to know (just like in clang-tidy!). I suspect this change affects developers or powerusers more than any others, and could accelerate debugging and/or configuring just a tiny bit more.
>
> > Is it for clang-tidy to avoid printing the checker name twice?
>
> Clang-tidy isnt affected, as they use the PD_NONE output type, not PD_TEXT.
> Clang-tidy isnt affected, as they use the PD_NONE output type, not PD_TEXT.
But they do have path notes printed out. It would have been terrible if they didn't have path notes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76605/new/
https://reviews.llvm.org/D76605
More information about the cfe-commits
mailing list