[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 24 02:07:53 PDT 2020


MyDeveloperDay added a comment.

I want to believe that it was a mistake on the original developers part, but I just can't tell.

A search of github shows people using this in their repos

https://github.com/search?q=ForContinuationAndIndentation&type=Code

I almost feel unless the original author can comment we are at an impasse, maybe we have to add:

`ForAllContinuationAndIndentation`

And if at some point in the future we can collapse both options into 1 then that would be better, but I just don't feel qualified to say change everyone when I don't use that option myself because I don't use tabs.

Whatever you add need to be heavily document that we mean everywhere, and if you ever find any cases where its doesn't work we intend for them to be changed. i.e. be very explicit in the review/commit comments


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75034/new/

https://reviews.llvm.org/D75034





More information about the cfe-commits mailing list