[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 23 13:06:38 PDT 2020


rjmccall added a comment.

In D74183#1937426 <https://reviews.llvm.org/D74183#1937426>, @efriedma wrote:

> I think we should remove the LangRef rule that says "sret" pointers have to be dereferenceable/naturally aligned, and let the frontend add explicit aligned/dereferenceable markings where appropriate.  (At that point, sret has no target-independent meaning; it's just to manipulate the target ABI.)  It would make the IR easier to understand, and resolves the interaction with opaque pointers.


That might be reasonable, yeah.  And yeah, making the `dereferenceable` assumption explicit is going to be necessary with opaque pointer types eventually.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74183/new/

https://reviews.llvm.org/D74183





More information about the cfe-commits mailing list