[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

Sean Fertile via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 23 10:21:49 PDT 2020


sfertile added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175
 namespace {
 /// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information.
 class PPC32_SVR4_ABIInfo : public DefaultABIInfo {
----------------
ZarkoCA wrote:
> sfertile wrote:
> > This name and comment is misleading, the class is used for both SVR4 and Darwin, and after this patch AIX. We need to fix the name comment to reflect that.
> Does this wording of the comment work? 
Missed updating the class name. Suggested: `PPC32_SVR4_ABIInfo` --> `PowerPC32ABIInfo`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76360/new/

https://reviews.llvm.org/D76360





More information about the cfe-commits mailing list