[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 20 10:50:23 PDT 2020


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2499
+        DIB.createFile(Mod.getModuleName(), TheCU->getDirectory()),
+        TheCU->getProducer(), false, StringRef(), 0, Mod.getASTFile(),
+        llvm::DICompileUnit::FullDebug, Signature);
----------------
probinson wrote:
> The isOptimized parameter changed from true to false?
Good catch, that was a drive-by fix. It has no meaning in the skeleton CU so we might as well not set it. Should be a separate commit though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76377/new/

https://reviews.llvm.org/D76377





More information about the cfe-commits mailing list