[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories

[Dmitry Polukhin via Phabricator via cfe-commits]

DmitryPolukhin added a comment.

In D75184#1932764 <https://reviews.llvm.org/D75184#1932764>, @alexfh wrote:

> There's one more thing to consider: just by looking at the name of a local option we don't know whether it will be read using `get()` or `getLocalOrGlobal()`. By removing local options we may introduce an even more surprising behavior than without this special treatment. WDYT?


As far as I can see there are no global options that can be used as local one. I found following global options: `IncludeStyle|StrictMode|HeaderFileExtensions|IgnoreMacros|EnableProto|CheckFirstDeclaration`
All of them used only with `getLocalOrGlobal()` and never with pure `get()` so on practice I think we shouldn't have this problem. If you still think that it is better to not remove local options, I can revert that part of my diff to the state before or implement approach that @njames93 suggested but IMHO it will be logic complication without real benefits right now. Please let me know what do you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75184/new/

https://reviews.llvm.org/D75184