[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

[Nathan Ridge via Phabricator via cfe-commits]

nridge created this revision.
nridge added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
nridge marked an inline comment as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:234
                   ParsedAST &AST, llvm::StringRef MainFilePath,
-                  const SymbolIndex *Index) {
+                  const SymbolIndex *Index, bool *IsDependentName) {
   const SourceManager &SM = AST.getSourceManager();
----------------
In the future, I can envision expanding this to return additional information, possibly the AST node itself. For now, I just started with a boolean.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76451

Files:
  clang-tools-extra/clangd/XRefs.cpp
  clang-tools-extra/clangd/XRefs.h
  clang-tools-extra/clangd/unittests/XRefsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76451.251462.patch
Type: text/x-patch
Size: 8768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200319/992ffc29/attachment-0001.bin>