[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

Wyatt Childers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 19 12:33:04 PDT 2020


wchilders added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmt.cpp:1095
+    // preventing the cached results from being used.
+    if (!isa<ConstantExpr>(fe)) {
+      enterFullExpression(fe);
----------------
This one is a bit weird, I think the comment explains it well, but I feel there should be a better way to handle this or if there are similar issues lurking elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76443/new/

https://reviews.llvm.org/D76443





More information about the cfe-commits mailing list