[PATCH] D76392: [AST] Make Expr::setDependence protected and remove add/removeDependence. NFC

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 19 00:30:43 PDT 2020


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/AST/Expr.h:2766
 
+  void markDependentForPostponedNameLookup() {
+    setDependence(getDependence() | ExprDependence::TypeValueInstantiation);
----------------
the method name seems too concrete to me, I'd prefer to drop `ForPostponedNameLookup`, though there is only one usage in Sema.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76392/new/

https://reviews.llvm.org/D76392





More information about the cfe-commits mailing list