[PATCH] D76262: [NFC] Add UsedDeclVisitor

Wed Mar 18 15:32:56 PDT 2020

[AMD Official Use Only - Internal Distribution Only]

I am taking a look. Thanks.

Sam

-----Original Message-----
From: Jacques Pienaar via Phabricator <reviews at reviews.llvm.org> 
Sent: Wednesday, March 18, 2020 6:14 PM
To: Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; rjmccall at gmail.com
Cc: jpienaar at google.com; cfe-commits at lists.llvm.org; mlekena at skidmore.edu; blitzrakete at gmail.com; shenhan at google.com
Subject: [PATCH] D76262: [NFC] Add UsedDeclVisitor

[CAUTION: External Email]

jpienaar added a comment.

This does not appear to be NFC:
 git checkout 704cd4d5d0754904361823588f203369c309deca <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FrG704cd4d5d0754904361823588f203369c309deca&data=02%7C01%7Cyaxun.liu%40amd.com%7Cc0896d5c9d714310dc4808d7cb89a135%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637201664290055700&sdata=8BcaFKoqT0gGlOi67UkgPCca5LIZSPHCoP%2FJCOkoG9U%3D&reserved=0> ; ninja check-mlir passes  git checkout 08ab8c9af4dd27cb306b449edc9a9c50ed11194a <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FrG08ab8c9af4dd27cb306b449edc9a9c50ed11194a&data=02%7C01%7Cyaxun.liu%40amd.com%7Cc0896d5c9d714310dc4808d7cb89a135%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637201664290055700&sdata=3VNtvfMjHhMoNtkzdXeV8%2FXJmR%2Bsqq5L7299ulSpVjQ%3D&reserved=0> ; ninja check-mlir fails with:

  0.      Program arguments: Compiles/build_clang/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/mlir/lib/Transforms -Illvm-project/mlir/lib/Transforms -Iinclude -Illvm-project/llvm/include -Illvm-project/mlir/include -Itools/mlir/include -fPIC -fvisibility-inl
  ines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/mlir/lib/Transforms/CMakeFiles/MLIRTransforms.dir/AffineDataCopyGeneration.cpp.o -MF tools/mlir/lib/Transforms/CMakeFiles/MLIRTransforms.dir/AffineDataCopyGeneration.cpp.o.d -o tools/mlir/lib/Transforms/CMakeFiles/MLIRTransforms.dir/AffineDataCopyGeneration.cpp.o -c llvm-project/mlir/lib/Transforms/AffineDataCopyGeneration.cpp
  1.      <eof> parser at end of file
  2.      Per-file LLVM IR generation
  3.      /usr/lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/unique_ptr.h:848:5: Generating code for declaration 'std::make_unique'
  build_clang/bin/clang++(_ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x1a)[0x55796bf8436a]
  build_clang/bin/clang++(_ZN4llvm3sys17RunSignalHandlersEv+0x34)[0x55796bf82204]
  build_clang/bin/clang++(_ZN4llvm3sys15CleanupOnSignalEm+0xf8)[0x55796bf82708]
  build_clang/bin/clang++(+0x1a58a08)[0x55796bf07a08]
  /lib/x86_64-linux-gnu/libpthread.so.0(+0x13520)[0x7f1b727f7520]
  /lib/x86_64-linux-gnu/libc.so.6(abort+0x121)[0x7f1b722bd535]
  /lib/x86_64-linux-gnu/libc.so.6(+0x2540f)[0x7f1b722bd40f]
  /lib/x86_64-linux-gnu/libc.so.6(+0x32b92)[0x7f1b722cab92]
  build_clang/bin/clang++(_ZN5clang7CodeGen15CodeGenFunction17EmitDeclRefLValueEPKNS_11DeclRefExprE+0x358)[0x55796c4cb138]
  build_clang/bin/clang++(_ZN5clang7CodeGen15CodeGenFunction10EmitLValueEPKNS_4ExprE+0x2f9)[0x55796c4ca6d9]
  build_clang/bin/clang++(_ZN5clang7CodeGen15CodeGenFunction14EmitCastLValueEPKNS_8CastExprE+0x103)[0x55796c4d4033]

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD76262%2Fnew%2F&data=02%7C01%7Cyaxun.liu%40amd.com%7Cc0896d5c9d714310dc4808d7cb89a135%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637201664290055700&sdata=sioR1S3m471EXAI17oUWgqmOeX26gk81APYiWOINl4M%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD76262&data=02%7C01%7Cyaxun.liu%40amd.com%7Cc0896d5c9d714310dc4808d7cb89a135%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637201664290055700&sdata=bPmzDOZM%2FHIO9hyIP0YIV5NLhpjF3luLTC%2Bw6BQYLd8%3D&reserved=0