[PATCH] D76385: Allow remapping Clang module include paths

[Adrian Prantl via Phabricator via cfe-commits]

aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2488
+  auto RemapPath = [&](std::string &Path) {
+    Path = remapDIPath(Path);
+    StringRef Relative(Path);
----------------
Is this legal?

remapDIPath takes a StringRef to Path. Is the sret value going to be a temporary or are we modifying the contents of the string while reading from it in remapDIPath?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76385/new/

https://reviews.llvm.org/D76385