[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`
Kristóf Umann via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 18 13:02:11 PDT 2020
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
The patch looks great, though I'd kindly ask you to wait a bit for someone with a bit more experience on `SVal`-smithing ;)
Generally speaking, I think the word you are looking for is "validate", not "verify", is that right, @whisperity?
================
Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp:49-50
+ typedef void (IteratorRangeChecker::*AdvanceFn)(CheckerContext &, SVal,
+ SVal) const;
+
----------------
Prefer `using`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76379/new/
https://reviews.llvm.org/D76379
More information about the cfe-commits
mailing list