[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

This seems misplaced - why is this in clang and not LLVM?



================
Comment at: clang/include/clang/Basic/TargetInfo.h:1192
+  // Get the cache line size of a given cpu. This method switches over
+  // the given cpu and returns `0` if the CPU is not found.
+  virtual Optional<unsigned> getCPUCacheLineSize() const { return None; }
----------------
Comment is no longer valid - returns `None` instead.
Also, might it be worth explicitly calling out that there is zero guarantees of stability of the returned values?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74918/new/

https://reviews.llvm.org/D74918