[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 18 08:09:01 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4232
QualType Ty) const {
- if (getTarget().getTriple().isOSDarwin()) {
+ // TODO: Add AIX ABI Info. Currently we are relying on PPC32_SVR4_ABIInfo to
+ // emit correct VAArg.
----------------
No need for two spaces. Add comma after "Currently".
================
Comment at: clang/test/CodeGen/aix-vararg.c:4
+// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s --check-prefix=32BIT
+#include <stdarg.h>
+
----------------
Can we use built-in types and functions in place of a header inclusion?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76360/new/
https://reviews.llvm.org/D76360
More information about the cfe-commits
mailing list