[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

Shiva Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 17 21:36:24 PDT 2020


shiva0217 added a comment.

In D57497#1927881 <https://reviews.llvm.org/D57497#1927881>, @apazos wrote:

> Shiva, how about making the flag small-data-limit alias of -msmall-data-threshold?


Hi @apazos, 
I try to implement -small-data-limit alias of -small-data-threshold, it will trigger the assertion "Multi-level aliases are not supported." in Option constructor because -msmall-data-threshold alias to -G. So I implement -small-data-limit alias of -G, then we can get -msmall-data-limit= and -msmall-data-threshold= inputs by OPT_G in SetRISCVSmallDataLimit(). In a meanwhile, warning of "Ignore -G because -msmall-data-limit= has higher priority" will be removed and -G may override -msmall-data-limit if -G is the last flag. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57497/new/

https://reviews.llvm.org/D57497





More information about the cfe-commits mailing list