[PATCH] D74361: [Clang] Undef attribute for global variables

Tue Mar 17 16:46:34 PDT 2020

JonChesterfield added a comment.

In D74361#1927863 <https://reviews.llvm.org/D74361#1927863>, @thakis wrote:

> This breaks tests on Windows: http://45.33.8.238/win/10664/step_7.txt
>
> Please take a look, and if it takes some time please revert while you investigate.

Thanks! It seems Windows inserts 'dso_local' into the middle of the generated IR.

I can't test on Windows so the two that failed CI are now marked as "UNSUPPORTED: system-windows".

Do you know a usual work around for variation in symbol visibility? I'm happy to copy it from another test but am wary of guessing what might work on Windows.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74361/new/

https://reviews.llvm.org/D74361