[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 17 15:40:47 PDT 2020
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:412
RanASTCallback = false;
- emitTUStatus({TUAction::BuildingPreamble, TaskName});
log("ASTWorker building file {0} version {1} with command {2}\n[{3}]\n{4}",
----------------
why are we moving this?
================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:433
- Details.BuildFailed = true;
- emitTUStatus({TUAction::BuildingPreamble, TaskName}, &Details);
// Report the diagnostics we collected when parsing the command line.
----------------
(and this)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76125/new/
https://reviews.llvm.org/D76125
More information about the cfe-commits
mailing list