[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 17 14:35:18 PDT 2020


nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:695
+      namespace ns { class [[Foo]] {}; }
+      using ns::[[F^oo]];
+    )cpp",
----------------
Why is it useful to give the using-declaration itself as a result?

It seems like the more useful behaviour from the user's point of view is to jump directly to the definition of `class Foo`, without having to choose from a popup first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74054/new/

https://reviews.llvm.org/D74054





More information about the cfe-commits mailing list