[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

Alexey Sachkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 17 10:11:08 PDT 2020


AlexeySachkov added inline comments.


================
Comment at: clang/include/clang/AST/Type.h:1827-1830
+    if (Dependent)
+      Deps |= TypeDependence::Dependent | TypeDependence::Instantiation;
+    if (InstantiationDependent)
+      Deps |= TypeDependence::Instantiation;
----------------
@ilya-biryukov, Is this code snippet correct?

It seems to be, that it should look like:
```
    if (Dependent)
      Deps |= TypeDependence::Dependent;
    if (InstantiationDependent)
      Deps |= TypeDependence::Dependent | TypeDependence::Instantiation;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71920/new/

https://reviews.llvm.org/D71920





More information about the cfe-commits mailing list