[PATCH] D76289: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 17 09:38:11 PDT 2020


aaron.ballman added a comment.

I cannot think of a way to add test coverage for this change, can you?



================
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2332
+    if (Header && Spellings.size() > 1)
+      OS <<  CreateSemanticSpellings(Spellings, SemanticToSyntacticMap);
 
----------------
Looks like there is a little extra whitespace after the `<<` that can be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76289/new/

https://reviews.llvm.org/D76289





More information about the cfe-commits mailing list