[PATCH] D73638: [AST] Move dependence computations into a separate file

[Haojian Wu via Phabricator via cfe-commits]

hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang/lib/AST/ComputeDependence.cpp:607
+  auto D = toExprDependence(E->getType()->getDependence());
+  for (auto *E : E->arguments())
+    D |= E->getDependence() & ~ExprDependence::Type;
----------------
dnsampaio wrote:
> I'm impressed this even compiled. With gcc 8.3 I get an error:
> ```
> /work/bf/LLVM/src/clang/lib/AST/ComputeDependence.cpp:607:18: error: use of ‘E’ before deduction of ‘auto’
>    for (auto *E : E->arguments())
>                   ^
> ```
yeah, it was compiled in clang. I saw a failure in the buildbot, fixed d3d844212fc96fb70f77431f0e6a70e0603b0a39.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73638/new/

https://reviews.llvm.org/D73638