[PATCH] D60748: Fix i386 struct and union parameter alignment

Mon Mar 16 23:25:32 PDT 2020

rjmccall added a comment.

In D60748#1925907 <https://reviews.llvm.org/D60748#1925907>, @LiuChen3 wrote:

> In D60748#1924794 <https://reviews.llvm.org/D60748#1924794>, @rjmccall wrote:
>
> > Oh, I see you just updated your patch months ago without ever mentioning that it was ready for review.
> >
> > It sounds to me like GCC retroactively added a switch specifying which version of the ABI to follow on this point, somewhat confusingly called `-malign-data`.  That's probably the right move here for us, too, especially since FreeBSD says they'd like to use it.  That also means the condition of when to use your new logic will have to change; basically, we need a CodeGenOption for this that will default to the old ABI, and the driver will pass down a different default on Linux.
>
>
> Thanks for review.
>
>   `-malign-data` is another topic. Just like what I said above, at least `-malign-data` will not affect the calling convention of struct and union. I agree with you that adding an option to control this new logi. I'll working on it.

Oh, I see, sorry.  Yes, I think a different option would be good.  We can debate the name when the patch is ready.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60748/new/

https://reviews.llvm.org/D60748