[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 15 20:24:59 PDT 2020


NoQ added a comment.

In D73521#1920130 <https://reviews.llvm.org/D73521#1920130>, @Charusso wrote:

> - The script actually creates a real world (hidden) checker.
>   - This checker always made with the build invocation.
>   - Its test file always made with the build invocation.


Mm, ok, but this checker is checked in into the repo and therefore can diverge from whatever the script generates, right? Or is each test run updating the repo? Can we simply make the script do `cat DummyChecker.cpp | sed s/DummyChecker/$NAME/g > $NAME.cpp` and store the checker only once?



================
Comment at: clang/utils/analyzer/add-new-checker.py:714-715
+                        help='the path to llvm-tblgen')
+    parser.add_argument('--force-creation', dest='is_force_creation',
+                        action='store_true', help=argparse.SUPPRESS)
+    parser.add_argument('--test', dest='is_test',
----------------
So, `--overwrite` and add help?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73521/new/

https://reviews.llvm.org/D73521





More information about the cfe-commits mailing list