[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

Fri Mar 13 15:07:59 PDT 2020

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang/utils/TableGen/SveEmitter.cpp:86
+  OS << "#ifndef  __cplusplus\n";
+  OS << "#include <stdbool.h>\n";
+  OS << "#endif\n\n";
----------------
sdesmalen wrote:
> efriedma wrote:
> > I'd prefer to avoid depending on stdbool if it isn't necessary.
> Section 3.3 of the ACLE actually mentions this explicitly:
> ```arm_sve.h includes stdint.h and so provides standard types such as uint32_t. When included from C code the header also includes stdbool.h and so provides the bool type.```
Oh, sorry, I was accidentally looking at an old version of the ACLE spec.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75298/new/

https://reviews.llvm.org/D75298