[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 12 14:39:24 PDT 2020
njames93 added a comment.
In D75901#1916119 <https://reviews.llvm.org/D75901#1916119>, @tetsuo-cpp wrote:
> @njames93 @MaskRay
> Thanks for helping me with testing. I'll remember this for next time.
>
> I also saw this pattern of retrieving `LangOptions` from an `ASTContext` in some other checks (`RedundantExpressionCheck` and `StaticAssertCheck`) but I didn't change them to use `getLangOpts` since the `ASTContext` is used for other stuff.
Its also not a good idea to change unrelated code in a review
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75901/new/
https://reviews.llvm.org/D75901
More information about the cfe-commits
mailing list