[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 12 13:05:09 PDT 2020


efriedma added inline comments.


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:86
+  OS << "#ifndef  __cplusplus\n";
+  OS << "#include <stdbool.h>\n";
+  OS << "#endif\n\n";
----------------
I'd prefer to avoid depending on stdbool if it isn't necessary.


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:92
+  OS << "typedef double float64_t;\n";
+  OS << "typedef bool bool_t;\n\n";
+
----------------
The ACLE documentation doesn't say anything about float16_t etc.?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75298/new/

https://reviews.llvm.org/D75298





More information about the cfe-commits mailing list