[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container
Kristóf Umann via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 11 11:19:10 PDT 2020
Szelethus added a comment.
The code from in `ExprInspectionChecker.cpp` is duplicated from D75677 <https://reviews.llvm.org/D75677>, isn't it?
================
Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:55
- ExplodedNode *reportBug(llvm::StringRef Msg, CheckerContext &C) const;
+ // Optional parameter `ExprVal` for expression value to be marked interesting
+ ExplodedNode *reportBug(llvm::StringRef Msg, CheckerContext &C,
----------------
Please terminate this sentence.
================
Comment at: clang/test/Analysis/container-modeling.cpp:100-101
- V.emplace_back(n); // expected-note 2{{Container 'V' extended to the right by 1 position}}
+ V.emplace_back(n); // expected-note{{Container 'V' extended to the right by 1 position}}
+ // expected-note at -1{{Container 'V' extended to the right by 1 position}}
----------------
Why did we unpack this? And the rest?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75514/new/
https://reviews.llvm.org/D75514
More information about the cfe-commits
mailing list