[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

Wed Mar 11 10:46:05 PDT 2020

tra marked an inline comment as done.
tra added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:51
+  // the latest version we support.
+  D.Diag(diag::warn_drv_unknown_cuda_version)
+      << MajorMinor << CudaVersionToString(CudaVersion::LATEST);
----------------
yaxunl wrote:
> We got some issue with this warning.
> 
> Basically CudaInstallationDetector is a member of GNU and other host toolchain and this check is done in the ctor.
> 
> If a user has latest CUDA SDK installed, clang will always emit a warning. If the user has -Werror set, which is quite common, compilation will always fail.
> 
> Is it possible only do this check for CUDA compilation?
> 
> Thanks.
Agreed. Clang should not warn about this unless it's a CUDA compilation. I'll get it fixed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73231/new/

https://reviews.llvm.org/D73231