[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

Paula Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 11 10:10:22 PDT 2020


PaulkaToast added a comment.

In D75786#1916714 <https://reviews.llvm.org/D75786#1916714>, @aaron.ballman wrote:

> In D75786#1916637 <https://reviews.llvm.org/D75786#1916637>, @RKSimon wrote:
>
> > @PaulkaToast This patch appears to have caused a buildbot issue, please can you investigate/revert: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/63869
>
>
> I believe the issue is that we're looking for system headers that are not mocked as part of the test. Sorry about not catching that earlier in the review! @PaulkaToast, you should create an empty `stdio.h` (and others used by your test) in Inputs/fucscia-restrict-system-includes/system so that we're not finding the actual system includes.


Working on that now, I'll send out a review shortly. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75786/new/

https://reviews.llvm.org/D75786





More information about the cfe-commits mailing list