[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Wed Mar 11 08:31:21 PDT 2020

baloghadamsoftware added a comment.

I do not say I fully grab every single character, but basically it looks good to me. @NoQ, please take a look on this, you are more competent in finding issues with it. This patch is needed to my patch preventing registration of checkers that depend on an analyzer option. Thx!

================
Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:217
+    mgr.template registerChecker<T>();
   }

----------------
Why do we need `MGR` here as template parameter? Is this function also used for other class instances than `CheckerManager`? I fail to see such invocation.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75360/new/

https://reviews.llvm.org/D75360