[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 11 07:58:39 PDT 2020
sammccall added a comment.
In D75443#1916909 <https://reviews.llvm.org/D75443#1916909>, @mibintc wrote:
> well, it would probably be quickest to separate the trailing storage into a separate patch. i'll try to get that submitted today. shall i submit that as a phabricator review or is there a different, preferred way to do that?
(Sorry our comments keep racing)
If you don't mind doing that, it'd be great - phabricator is the best way.
I'm happy to do my best reviewing, but haven't made a similar change myself, so getting rjmccall's eyes on it would definitely get you a better check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75443/new/
https://reviews.llvm.org/D75443
More information about the cfe-commits
mailing list