[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 11 06:18:09 PDT 2020


sammccall added a comment.

As discussed offline... this undoes a desirable optimization from D54526 <https://reviews.llvm.org/D54526>.

A couple of possible ways to avoid this:

- FPOptions integer encoding can fit into 7 bits: combine integer behavior + exception behavior into 3 x 5 = 15 states that fits in 4 bits.
- IsOMPStructuredBlock bit is basically unused (just for AST dump and an unused ASTMatcher), that bit could be dropped

Former is probably the eaisest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75443/new/

https://reviews.llvm.org/D75443





More information about the cfe-commits mailing list